Split up the upload vs deploy status messages

[jhaynie]

Summary by CodeRabbit

• Enhancements
  • Improved user interface feedback by displaying separate progress indicators for the upload and deployment steps during the deployment process.

[coderabbitai]

Walkthrough

The changes refactor the deployment process in cmd/cloud.go by splitting the upload and deploy steps into two separate actions, each wrapped with its own spinner for clearer UI feedback. The upload and deployment logic are now handled in distinct functions, improving the separation of process phases.

Changes

File(s)	Change Summary
cmd/cloud.go	Refactored upload and deploy logic into separate functions; added individual spinner UI for each step.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant TUI
    participant CloudAPI

    User->>CLI: Initiate deployment
    CLI->>TUI: ShowSpinner("Uploading ...", uploadAction)
    TUI->>CLI: Calls uploadAction
    CLI->>CloudAPI: Upload encrypted zip
    CloudAPI-->>CLI: Upload response
    CLI->>TUI: ShowSpinner("Deploying ...", deployAction)
    TUI->>CLI: Calls deployAction
    CLI->>CloudAPI: Update deployment status to completed
    CloudAPI-->>CLI: Status update response
    CLI->>CloudAPI: Fetch webhook API key (if applicable)
    CloudAPI-->>CLI: API key response

Loading

Possibly related PRs

• Improvements around packaging #368: Refactored deployment steps to use spinner-wrapped preflight and upload actions, which this PR further extends by splitting and clarifying the deployment phases.

Suggested reviewers

• pec1985

Poem

In the cloud, the spinners spin,
Uploads start, deployments begin.
Two steps now, each clear and bright,
Progress shown in gentle light.
Rabbits cheer as code takes flight—
Refactored paths, a tidy sight!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e995e5e and e3ca3d6.

📒 Files selected for processing (1)

• cmd/cloud.go (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Build and Test (macos-latest)
• GitHub Check: Test CLI Upgrade Path (windows-latest)
• GitHub Check: Analyze (go)

🔇 Additional comments (4)

cmd/cloud.go (4)

540-576: LGTM - Clean separation of upload logic

The uploadAction function is well-structured with proper error handling. The logic correctly uploads the encrypted zip file and handles both network errors and HTTP error responses by updating the deployment status to "failed" before exiting.

---

578-578: LGTM - Clear upload progress indication

The spinner message "Uploading ..." provides clear feedback to users about the current operation phase.

---

580-595: LGTM - Well-structured deploy completion logic

The deployAction function properly handles the deployment completion workflow:

1. Updates deployment status to "completed"
2. Conditionally fetches webhook token when there's exactly one agent with types

The error handling is consistent with the rest of the codebase.

---

597-597: LGTM - Clear deploy progress indication

The spinner message "Deploying ..." clearly indicates the deployment phase, completing the separation of upload vs deploy feedback as intended by the PR objectives.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch separate-status-deploy

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.