Skip to content

Split up the upload vs deploy status messages #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhaynie merged 1 commit into from
Jun 19, 2025
Merged

Split up the upload vs deploy status messages #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmd/cloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ Examples:
started := time.Now()
var webhookToken string

action := func() {
uploadAction := func() {
url := util.TransformUrl(startResponse.Data.Url)
// send the zip file to the upload endpoint provided
logger.Trace("uploading to %s", url)
Expand Down Expand Up @@ -573,7 +573,11 @@ Examples:
}
resp.Body.Close()
logger.Debug("deployment uploaded %d bytes in %v", fi.Size(), time.Since(started))
}

tui.ShowSpinner("Uploading ...", uploadAction)

deployAction := func() {
// tell the api that we've completed the upload for the deployment
if err := updateDeploymentStatusCompleted(logger, apiUrl, token, startResponse.Data.DeploymentId); err != nil {
errsystem.New(errsystem.ErrApiRequest, err,
Expand All @@ -590,7 +594,7 @@ Examples:
}
}

tui.ShowSpinner("Uploading ...", action)
tui.ShowSpinner("Deploying ...", deployAction)

format, _ := cmd.Flags().GetString("format")
if format == "json" {
Expand Down
Loading