AGENT-424 Railgurd the user from creating a project in an existing project directory

[yoav0gal]

Summary by CodeRabbit

• New Features

  • Added a safeguard to prevent accidental creation of a new project inside an existing project directory. Users are now prompted for confirmation if a project already exists, with clear guidance and options provided.

• Bug Fixes

  • Improved error handling in non-interactive mode to prevent unintended project creation within existing directories.

[coderabbitai]

Walkthrough

A safeguard was added to the project creation command to detect if the current directory is already an Agentuity project. In interactive mode, users are warned and prompted to confirm before proceeding. In non-interactive mode, the command aborts with an error, preventing accidental project nesting or overwriting.

Changes

File(s)	Change Summary
cmd/project.go	Added logic to check for existing project directory before creating a new project, with user prompts and error handling for both interactive and non-interactive modes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant Filesystem

    User->>CLI: Run project create command
    CLI->>Filesystem: Check if current directory is a project
    alt Directory is a project
        alt Interactive mode (TTY)
            CLI->>User: Display warning and prompt for confirmation
            User->>CLI: Confirm or decline
            alt User declines
                CLI->>User: Exit with success message
            else User confirms
                CLI->>User: Warn and continue with project creation
            end
        else Non-interactive mode
            CLI->>User: Fatal error, abort command
        end
    else Directory is not a project
        CLI->>User: Continue with project creation
    end

Loading

Possibly related PRs

• Don't run git init when you are in a git repo #362: Both PRs modify the project creation flow in projectNewCmd to add safeguards, addressing different aspects of project initialization logic.

Suggested reviewers

• pec1985
• jhaynie
• robindiddams

Poem

In burrows deep, a project grows,
But nested holes? The rabbit knows!
With gentle checks and prompts so clear,
Accidents are far from here.
Hop on, create with peace of mind,
For careful code is well-designed! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c54009 and a6a528d.

📒 Files selected for processing (1)

• cmd/project.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Test CLI Upgrade Path (windows-latest)
• GitHub Check: Build and Test (macos-latest)
• GitHub Check: Analyze (go)

🔇 Additional comments (1)

cmd/project.go (1)

319-357: Excellent safeguard implementation with good UX considerations.

The railguard mechanism is well-implemented with appropriate handling for both interactive and non-interactive modes:

• Interactive mode provides clear warnings and alternatives before prompting for confirmation
• Non-interactive mode fails fast with helpful error messages and alternative commands
• The messaging is user-friendly and actionable

The implementation correctly prevents accidental project nesting while giving users the option to proceed if intentional.

Let me verify that the project.ProjectExists function is properly implemented:

#!/bin/bash
# Description: Verify the ProjectExists function implementation and usage
# Expected: Find the function definition and confirm it properly detects existing projects

echo "Searching for ProjectExists function definition..."
ast-grep --pattern 'func ProjectExists($$$) $$$'

echo -e "\nSearching for project detection logic..."
rg -A 10 "ProjectExists"

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch yoav/agent-403-create-project-import-railgard

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.