Update eslint#518
Closed
ariporad wants to merge 2 commits intoairbnb:masterfrom
ariporad:update-eslint
Closed
Conversation
Collaborator
There was a problem hiding this comment.
tbh this type of change to me is an indicator that perhaps we don't wan't id-length in the first place - t is the conventional argument name here for tape, and using an abbreviated "test" seems hacky.
Collaborator
There was a problem hiding this comment.
yeah - but in that case we should ammend the styleguide as well to say 1-letter vars are ok in some cases
Collaborator
There was a problem hiding this comment.
I think they always make sense as iteration variables in loops, and in tape tests, to begin with.
Closed
Collaborator
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update eslint to v1.4.x
Fixes #515.