Skip to content

Update eslint #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ariporad wants to merge 2 commits into from
+23 −23
Closed

Update eslint #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4ffa7f
update eslint
Sep 18, 2015
556f36e
update tests to comply with id-length
Sep 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-config-airbnb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"devDependencies": {
"babel-eslint": "4.0.10",
"babel-tape-runner": "1.2.0",
"eslint": "1.1.0",
"eslint": "^1.4.3",
"eslint-plugin-react": "3.2.3",
"react": "0.13.3",
"tape": "4.2.0"
Expand Down
8 changes: 4 additions & 4 deletions packages/eslint-config-airbnb/test/test-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import test from 'tape';
import base from '../base';

test('base: does not reference react', t => {
t.plan(2);
test('base: does not reference react', tst => {
Copy link
Collaborator

@ljharb ljharb Sep 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh this type of change to me is an indicator that perhaps we don't wan't id-length in the first place - t is the conventional argument name here for tape, and using an abbreviated "test" seems hacky.

Copy link
Collaborator

@justjake justjake Sep 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - but in that case we should ammend the styleguide as well to say 1-letter vars are ok in some cases

Copy link
Collaborator

@ljharb ljharb Sep 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they always make sense as iteration variables in loops, and in tape tests, to begin with.

tst.plan(2);

t.notOk(base.plugins, 'plugins is unspecified');
tst.notOk(base.plugins, 'plugins is unspecified');

// scan rules for react/ and fail if any exist
const reactRuleIds = Object.keys(base.rules)
.filter(ruleId => ruleId.indexOf('react/') === 0);
t.deepEquals(reactRuleIds, [], 'there are no react/ rules');
tst.deepEquals(reactRuleIds, [], 'there are no react/ rules');
});
36 changes: 18 additions & 18 deletions packages/eslint-config-airbnb/test/test-react-order.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ ${body}
`;
}

test('validate react prop order', t => {
t.test('make sure our eslintrc has React linting dependencies', t => {
t.plan(2);
t.equal(eslintrc.parser, 'babel-eslint', 'uses babel-eslint');
t.equal(eslintrc.plugins[0], 'react', 'uses eslint-plugin-react');
test('validate react prop order', tst => {
tst.test('make sure our eslintrc has React linting dependencies', tst => {
tst.plan(2);
tst.equal(eslintrc.parser, 'babel-eslint', 'uses babel-eslint');
tst.equal(eslintrc.plugins[0], 'react', 'uses eslint-plugin-react');
});

t.test('passes a good component', t => {
t.plan(3);
tst.test('passes a good component', tst => {
tst.plan(3);
const result = lint(wrapComponent(`
componentWillMount() { }
componentDidMount() { }
Expand All @@ -42,13 +42,13 @@ test('validate react prop order', t => {
render() { return <div />; }
`));

t.notOk(result.warningCount, 'no warnings');
t.notOk(result.errorCount, 'no errors');
t.deepEquals(result.messages, [], 'no messages in results');
tst.notOk(result.warningCount, 'no warnings');
tst.notOk(result.errorCount, 'no errors');
tst.deepEquals(result.messages, [], 'no messages in results');
});

t.test('order: when random method is first', t => {
t.plan(2);
tst.test('order: when random method is first', tst => {
tst.plan(2);
const result = lint(wrapComponent(`
someMethod() { }
componentWillMount() { }
Expand All @@ -60,12 +60,12 @@ test('validate react prop order', t => {
render() { return <div />; }
`));

t.ok(result.errorCount, 'fails');
t.equal(result.messages[0].ruleId, 'react/sort-comp', 'fails due to sort');
tst.ok(result.errorCount, 'fails');
tst.equal(result.messages[0].ruleId, 'react/sort-comp', 'fails due to sort');
});

t.test('order: when random method after lifecycle methods', t => {
t.plan(2);
tst.test('order: when random method after lifecycle methods', tst => {
tst.plan(2);
const result = lint(wrapComponent(`
componentWillMount() { }
componentDidMount() { }
Expand All @@ -77,7 +77,7 @@ test('validate react prop order', t => {
render() { return <div />; }
`));

t.ok(result.errorCount, 'fails');
t.equal(result.messages[0].ruleId, 'react/sort-comp', 'fails due to sort');
tst.ok(result.errorCount, 'fails');
tst.equal(result.messages[0].ruleId, 'react/sort-comp', 'fails due to sort');
});
});