CHANGELOGの更新をunreleasedフォルダ内で行うようにする #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salano-ym
reviewed
May 14, 2024
salano-ym
approved these changes
May 16, 2024
FineArchs
requested review from
ikasoba,
kakkokari-gtyih,
marihachi,
syuilo and
uzmoi
uzmoi
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#662 でも言ったように、CHANGELOG.mdに直接書き込む方法ではあるPRがマージされるごとに他のPRにconflictが発生して煩雑です。
これを解決するために、unreleasedフォルダを用意してCHANGELOGの更新内容はPRごとに別のファイルとしてここに置き、リリースの際にまとめてCHANGELOG.mdに反映させる形式にします。
Details
具体的には
npm run pre-releaseがCHANGELOG.mdへの反映を行うコマンドです。これを実行しなければprepublishOnlyに設定されているチェック機構に引っかかりpublishが行えない仕組みになっています。また、環境変数
NEWVERSIONが設定されている場合pre-releaseコマンドはpackage.jsonのバージョンアップも行います。これを利用し、nightlyリリースのworkflowを少しだけ分かりやすく書き換えています。
ついでにdevとnextで分かれていたnightlyリリースのworkflowを統合したり、unstableなjson importを除去したりしています。