Enhance: Ability to choose random number generator algorithm for Math:gen_rng
#731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it matches the `tsconfig.json`
* Refactored `Math:rnd_unbiased` to use crypto * Refactored `Math:gen_rng_unbiased` to use `SeedRandomWrapper`
* Updated `std-math.md`
* Refactored `Math:rnd` to use `crypto` * Refactored `Math:rnd_unbiased` to use `crypto`
* Reduced potential random test failure
This was referenced Jul 29, 2024
Member
|
改めて確認しましたが、package-lock.jsonが更新されていないことでworkflowの検証に失敗しているようですね。 |
Contributor
Author
|
修正しました。 |
Member
|
あと、 #666 でCHANGELOGの書き方が変わりました。 |
Contributor
Author
|
移動しました。 |
FineArchs
approved these changes
Jul 29, 2024
… `VNativeFn | VNull`
Contributor
Author
以上の変更を行いました。 |
* Fixed potential overflow in ChaCha20
FineArchs
reviewed
Aug 3, 2024
…undefined` * Invalid type for `seed` now throws exception in `Math:gen_rng`
FineArchs
approved these changes
Aug 3, 2024
FineArchs
requested review from
ikasoba,
kakkokari-gtyih,
marihachi,
salano-ym,
syuilo and
uzmoi
and removed request for
ikasoba,
kakkokari-gtyih,
marihachi,
salano-ym,
syuilo and
uzmoi
uzmoi
approved these changes
Aug 4, 2024
Member
|
条件を満たしたのでマージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Math:gen_rngに第二引数algorithmを追加します。アルゴリズムを
chacha20、rc4、rc4_legacy(従来のアルゴリズム)から選べるようになります。Why
#489 でアルゴリズムの変更についての議論がありましたが、アルゴリズムを選べるようにすることにより、現行の挙動を必要とするプログラムは、
algorithmをrc4_legacyとするだけで従来の挙動を利用できるようになります。Additional info (optional)
Resolves #489