Skip to content

Conversation

@aalavandhan
Copy link
Member

@aalavandhan aalavandhan commented Nov 29, 2022

  • Smock for contract mocks
  • Added tests for rollover vault flows

@aalavandhan aalavandhan force-pushed the rollover-vault branch 2 times, most recently from 37ea215 to 57bb76c Compare January 12, 2023 16:59
@aalavandhan aalavandhan added the WIP work in progress label Feb 1, 2023
@aalavandhan aalavandhan force-pushed the vault-unit-tests branch 3 times, most recently from 3e0bc6f to 2bb2eeb Compare February 8, 2023 22:20
@aalavandhan aalavandhan changed the title WIP: Vault unit tests Vault unit tests Feb 23, 2023
@aalavandhan aalavandhan added next-release Changes for upcoming release and removed WIP work in progress labels Feb 23, 2023
@aalavandhan aalavandhan changed the title Vault unit tests Rollover vault tests Feb 23, 2023
@aalavandhan aalavandhan force-pushed the rollover-vault branch 5 times, most recently from 2c16c13 to baadd9d Compare March 29, 2023 16:36
Base automatically changed from rollover-vault to main April 10, 2023 13:40
Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* fee strategy update

* updated testcase text

* removed single use variable

* Apply suggestions from code review

Co-authored-by: Brandon Iles <brandon@fragments.org>

* code review fixes

* Vault interface (#141)

* standard vault interface

* linter update

---------

Co-authored-by: Brandon Iles <brandon@fragments.org>
@aalavandhan aalavandhan merged commit 42e7a19 into main Apr 18, 2023
@aalavandhan aalavandhan deleted the vault-unit-tests branch April 18, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next-release Changes for upcoming release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants