Vault interface #141
Merged
Vault interface #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aalavandhan
commented
Apr 10, 2023
aalavandhan
commented
- Standard interface definition for vaults
- Updated the deposit "function" signature (now doesn't accept the input asset)
aalavandhan
force-pushed
the
vault-interface
branch
from
f990daf to
b16ec52
Compare
aalavandhan
added a commit
that referenced
this pull request
Apr 18, 2023
* fee strategy update * updated testcase text * removed single use variable * Apply suggestions from code review Co-authored-by: Brandon Iles <brandon@fragments.org> * code review fixes * Vault interface (#141) * standard vault interface * linter update --------- Co-authored-by: Brandon Iles <brandon@fragments.org>
aalavandhan
added a commit
that referenced
this pull request
Apr 18, 2023
* bumped up compiler version * using smock for contract mocks * vault unit tests * ran linter * using require instead of assert for init check * fixed underflow bug with array index * Debasement aware Fee strategy (#140) * fee strategy update * updated testcase text * removed single use variable * Apply suggestions from code review Co-authored-by: Brandon Iles <brandon@fragments.org> * code review fixes * Vault interface (#141) * standard vault interface * linter update --------- Co-authored-by: Brandon Iles <brandon@fragments.org> --------- Co-authored-by: Brandon Iles <brandon@fragments.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.