-
Notifications
You must be signed in to change notification settings - Fork 12
Restructuring perp/vault fees #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aalavandhan
commented
Mar 8, 2025
- Perp's mint/burn fees are paid to the vault (by minting/transfering perp tokens)
- All fees collected during flash swaps go to the vault's balance. (before it was split between perp and the vault)
- Added owner defined drSoftBounds (similar to bill broker), which determine when flash swap fees transition from constant value to the linearly increasing fee (previously the kink point was dr=1.0).
Restructuring perp/vault fees
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
brandoniles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good here, but do we have everything needed for the frontend to be able to represent fee activity?
Suggestions Co-authored-by: Brandon Iles <brandon@fragments.org>
Co-authored-by: Brandon Iles <brandon@fragments.org>
The mint/redeem preview functions should compute the fees and adjust for it. The UI should pick that up I think .. |
brandoniles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Brandon Iles <brandon@fragments.org>
Co-authored-by: Brandon Iles <brandon@fragments.org>
Rebalancing updates
Pair operations
Removed rollover fees in favor of daily rebalance