Skip to content

Conversation

@aalavandhan
Copy link
Member

  1. Perp's mint/burn fees are paid to the vault (by minting/transfering perp tokens)
  2. All fees collected during flash swaps go to the vault's balance. (before it was split between perp and the vault)
  3. Added owner defined drSoftBounds (similar to bill broker), which determine when flash swap fees transition from constant value to the linearly increasing fee (previously the kink point was dr=1.0).

@openzeppelin-code
Copy link

openzeppelin-code bot commented Mar 8, 2025

Restructuring perp/vault fees

Generated at commit: abc11646cd41cd6c18983f280d3e62f560690896

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
0
0
3
25
29
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good here, but do we have everything needed for the frontend to be able to represent fee activity?

@aalavandhan
Copy link
Member Author

I think we're good here, but do we have everything needed for the frontend to be able to represent fee activity?

The mint/redeem preview functions should compute the fees and adjust for it. The UI should pick that up I think ..

@aalavandhan aalavandhan added WIP work in progress in-review Currently in review and removed WIP work in progress labels Apr 1, 2025
Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalavandhan aalavandhan removed the in-review Currently in review label Apr 3, 2025
@aalavandhan aalavandhan merged commit eed0d39 into ethers-update Apr 18, 2025
@aalavandhan aalavandhan deleted the fee-restructure branch April 18, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants