Skip to content

Conversation

@daniel-graham-amplitude
Copy link
Collaborator

@daniel-graham-amplitude daniel-graham-amplitude commented Jan 2, 2026

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

Note

Simplifies .github/workflows/publish-v2.yml to address pnpm -- argument handling and remove unused publish modes.

  • Removes publishFrom input and related PUBLISH_FROM env; always run Create release version (drops from-package path)
  • Fixes pnpm invocations by removing extraneous -- and passing flags directly in deploy, prerelease, and dry-run steps
  • Minor cleanup: consolidate comments ("Publish to NPM"), no other logic changes to tests or permissions

Written by Cursor Bugbot for commit ea23b0f. This will update automatically on new commits. Configure here.

@daniel-graham-amplitude daniel-graham-amplitude merged commit 7c1a535 into pnpm-migration Jan 2, 2026
12 checks passed
@daniel-graham-amplitude daniel-graham-amplitude deleted the AMP-145286-fix-pnpm-script branch January 2, 2026 19:04
@daniel-graham-amplitude daniel-graham-amplitude restored the AMP-145286-fix-pnpm-script branch January 2, 2026 19:04
@macroscopeapp
Copy link
Contributor

macroscopeapp bot commented Jan 2, 2026

Fix PNPM flag handling and always run Deploy job Create release version step in publish-v2.yml to support migration to PNPM

Remove workflow_dispatch.publishFrom and PUBLISH_FROM usage, make Create release version unconditional in Deploy, and pass CLI flags directly to PNPM scripts without -- in pre-release steps in publish-v2.yml.

🖇️ Linked Issues

Progresses PNPM migration in AMP-145286 under the security remediation epic AMP-145285 and the initiative AMP-91393 by correcting workflow flag handling and release step execution.

📍Where to Start

Start with the workflow_dispatch inputs and the Deploy job Create release version step in publish-v2.yml.


Macroscope summarized ea23b0f.

# Only create release version when using from-git (default behavior)
# from-package mode uses existing package.json versions and doesn't need git tags
- name: Create release version
if: ${{ env.PUBLISH_FROM != 'from-package' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent pnpm argument separator fix at line 97

The PR removes the -- separator from pnpm commands to fix a pnpm problem, but line 97 in the deploy:version command still contains -- -y while similar commands at lines 177, 182, and 188 had this separator removed. This inconsistency means the release workflow path will still experience the same pnpm issue that this PR intends to fix.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants