Skip to content

chore: fix -- problem with pnpm #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-graham-amplitude merged 1 commit into from
Jan 2, 2026
Merged

chore: fix -- problem with pnpm #1462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions .github/workflows/publish-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ on:
- release
- prerelease
- dry-run
publishFrom:
type: string
description: Publish source (leave empty for from-git, or enter "from-package"). Only applies to 'release' type.
required: false
branch:
type: string
description: Branch to create pre-release from (only applies to prerelease/dry-run).
Expand Down Expand Up @@ -74,8 +70,6 @@ jobs:
permissions:
id-token: write # Required for OIDC
contents: write
env:
PUBLISH_FROM: ${{ github.event.inputs.publishFrom || 'from-git' }}
strategy:
matrix:
node-version: [24.x] # Ensure npm 11.5.1 or later is installed for OIDC, node 24.6 is minimal
Expand All @@ -95,7 +89,6 @@ jobs:
# Only create release version when using from-git (default behavior)
# from-package mode uses existing package.json versions and doesn't need git tags
- name: Create release version
if: ${{ env.PUBLISH_FROM != 'from-package' }}
Copy link

@cursor cursor bot Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent pnpm argument separator fix at line 97

The PR removes the -- separator from pnpm commands to fix a pnpm problem, but line 97 in the deploy:version command still contains -- -y while similar commands at lines 177, 182, and 188 had this separator removed. This inconsistency means the release workflow path will still experience the same pnpm issue that this PR intends to fix.

Additional Locations (1)

Fix in Cursor Fix in Web

run: |
echo "Running lerna version..."

Expand Down Expand Up @@ -124,10 +117,7 @@ jobs:

echo "✅ Successfully created release version"

# Publish to NPM using from-git or from-package:
# - from-git: Publishes packages tagged by 'lerna version' in the current commit (requires prior versioning)
# - from-package: Compares package.json versions with NPM registry, publishes any versions not present in registry
# See: https://lerna.js.org/docs/features/version-and-publish#from-package
# Publish to NPM
- name: Publish Release to NPM
run: |
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:publish
Expand Down Expand Up @@ -184,18 +174,18 @@ jobs:
- name: Dry run pre-release version
if: ${{ github.event.inputs.releaseType == 'dry-run' }}
run: |
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:version:dry-run -- -y --no-private --conventional-prerelease --preid ${{ env.PREID }} --allow-branch ${{ steps.determine-branch.outputs.branch }} --no-changelog --no-push --no-git-tag-version
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:version:dry-run -y --no-private --conventional-prerelease --preid ${{ env.PREID }} --allow-branch ${{ steps.determine-branch.outputs.branch }} --no-changelog --no-push --no-git-tag-version

- name: Pre-release version
if: ${{ github.event.inputs.releaseType == 'prerelease' }}
run: |
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:version -- -y --no-private --conventional-prerelease --preid ${{ env.PREID }} --allow-branch ${{ steps.determine-branch.outputs.branch }} --create-release github
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:version -y --no-private --conventional-prerelease --preid ${{ env.PREID }} --allow-branch ${{ steps.determine-branch.outputs.branch }} --create-release github

# Use 'from git' option if `lerna version` has already been run
- name: Publish Pre-release to NPM
if: ${{ github.event.inputs.releaseType == 'prerelease' }}
run: |
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:publish -- -y --ignore-scripts --tag ${{ env.PREID }}
GH_TOKEN=${{ secrets.GH_PUBLISH_TOKEN }} pnpm deploy:publish -y --ignore-scripts --tag ${{ env.PREID }}
env:
S3_BUCKET_NAME: ${{ secrets.S3_BUCKET_NAME }}

Expand Down
Loading