Kfactors io#13
Merged
Merged
Conversation
Collaborator
Author
|
@andreab1997 you can review this PR before #14 |
andreab1997
approved these changes
Feb 28, 2023
|
|
||
| class KfactorRunner: | ||
| def __init__(self, t_card_name, o_card_name, pdf_name): | ||
| def __init__(self, t_card_name, dataset_name, pdf_name, use_yadism): |
Owner
There was a problem hiding this comment.
Is the use_yadism flag needed for the NNLO part?
Collaborator
Author
There was a problem hiding this comment.
yes this is a nice feature, you can do kfact both DISTP/DISTP ((pto+1)/pto) or DISTB/YADISM (same order)
Owner
There was a problem hiding this comment.
And can you also do YADISM/YADISM in principle?
Collaborator
Author
There was a problem hiding this comment.
no you can't... do you want to support this feature?
Owner
There was a problem hiding this comment.
Maybe in the future this can be handy but for the moment let's just open an issue (I am doing that)
Owner
|
Ok so, for me we can merge this. When you want @giacomomagni, pls do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.