Skip to content

Addition of Ftotal and Flight#14

Merged
giacomomagni merged 36 commits into
masterfrom
add_f_total
Mar 1, 2023
Merged

Addition of Ftotal and Flight#14
giacomomagni merged 36 commits into
masterfrom
add_f_total

Conversation

@giacomomagni
Copy link
Copy Markdown
Collaborator

In this PR we add the possibility to compute F2_total and FL_total

@giacomomagni giacomomagni changed the base branch from master to kfactors_io February 10, 2023 10:43
@giacomomagni giacomomagni mentioned this pull request Feb 10, 2023
15 tasks
@giacomomagni giacomomagni mentioned this pull request Feb 13, 2023
@giacomomagni giacomomagni changed the base branch from kfactors_io to master February 28, 2023 14:45
Copy link
Copy Markdown
Owner

@andreab1997 andreab1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just started the review, I am going to complete it tomorrow

Comment thread benchmarks/bench_yadism.py
Comment thread benchmarks/bench_yadism.py
Comment thread dis_tp.toml
@@ -1,5 +1,5 @@
obs:
F2:
F2_charm:
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you changed also the others?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, shall I update also the others?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible yes. Once we merge we should try to produce all the results with master and do the plot

@giacomomagni giacomomagni merged commit 69d2c72 into master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants