Non-Failing withResource#267
Closed
rainerhahnekamp wants to merge 3 commits intoangular-architects:mainfrom
Closed
Non-Failing withResource#267rainerhahnekamp wants to merge 3 commits intoangular-architects:mainfrom
withResource#267rainerhahnekamp wants to merge 3 commits intoangular-architects:mainfrom
Conversation
Collaborator
|
I'll give a formal review when this is marked ready, but this looks like a solid plan. |
3fd20ca to
a594d32
Compare
Collaborator
|
Would it be possible to set a provider for an app config for the default error behavior? |
Collaborator
Author
Good idea @michael-small |
Collaborator
|
Reason: With our mindset and approach for error handling having shifted to use a proxy, we have closed this in favor of #270 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #242