Conversation
- fix withEntityResource - add additional type tests - make `undefined value` as the default error handling
michael-small
left a comment
michael-small
left a comment
There was a problem hiding this comment.
Besides a call for named withEntityResource tests for error handling, most other comments are nitpicks of jsdocs or pre-existing TODO comments. But all the business logic looks solid.
| warningSpy.mockClear(); | ||
| }); | ||
|
|
||
| //TODO wait for https://github.com/ngrx/platform/pull/4932 and then add 'value' to the list |
There was a problem hiding this comment.
Old outstanding TODO
There was a problem hiding this comment.
I don't think it belongs in this PR since it would not be possible to backport it to v20. I would recommend doing a separate PR for that. If you want you can do it.
There was a problem hiding this comment.
No big deal, some other time then
| }, | ||
| ); | ||
|
|
||
| //TODO wait for https://github.com/ngrx/platform/pull/4932 |
There was a problem hiding this comment.
Old outstanding TODO
There was a problem hiding this comment.
Separate issue (see above)
| }); | ||
| }); | ||
|
|
||
| describe('Signature Tests', () => { |
There was a problem hiding this comment.
Needs named equivalents right?
Co-authored-by: Michael Small <33669563+michael-small@users.noreply.github.com>
Co-authored-by: Michael Small <33669563+michael-small@users.noreply.github.com>
Co-authored-by: Michael Small <33669563+michael-small@users.noreply.github.com>
Co-authored-by: Michael Small <33669563+michael-small@users.noreply.github.com>
3 participants
Replaces the computed linkedSignal with the direct resource value, using a Proxy on the get trap to ensure fail-safe access.