Closed
Conversation
Member
|
Awesome! Thanks a lot @cthrax. Could you squash all the commits and fix the message? |
…lext travis commands
Author
|
I think that should do it, I had to do a --force push due to all the previous pushes, but that shouldn't effect the pull request I think. |
Contributor
|
I think #133 has fixed this issue, so I'm closing it. If that isn't the case feel free to reopen. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #91 . Basically just needed to make sure nvm was installed before proceeding, might be other differences in the future, but for now all tests pass with just that.