osx travis config and basic e2e test suite #133
Closed
jkuri wants to merge 1 commit intoangular:masterfrom
jkuri:master
Closed
osx travis config and basic e2e test suite #133jkuri wants to merge 1 commit intoangular:masterfrom jkuri:master
jkuri wants to merge 1 commit intoangular:masterfrom
jkuri:master
Conversation
Closed
Contributor
Contributor
|
Could you rebase on master? |
Member
|
Can you add two separated commits? One for Travis setup and the other with the basic e2e test suite stuff? |
Contributor
Author
|
Sure, I'll rebase and make separated commits. |
Member
|
@jkuri please let me know if you need any help, we can share screens to get it done |
Contributor
Author
|
@cironunes thanks, sure I will let you know, right now I am writing tests for #135. My skype name is recoil_x btw. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem as travis osx configuration did not find nvm. Fixed now.
Related issue: #91.
It also applies on basic e2e test suite issue #90