feat(@schematics/angular): extend tslint:recommended#13213
feat(@schematics/angular): extend tslint:recommended#13213hansl merged 1 commit intoangular:masterfrom
Conversation
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
From my end this LGTM.
Waiting for @mgechev to confirm.
| "check-space" | ||
| ], | ||
| "curly": true, | ||
| "adjacent-overload-signatures": false, |
There was a problem hiding this comment.
Looks like in the current CLI and tslint this has value true, lmk if I'm wrong.
There was a problem hiding this comment.
Hmm, I don't think it is present in the current tslint.json, so I guess it's not activated (unless I'm missing something?).
|
|
mgechev
left a comment
mgechev
left a comment
There was a problem hiding this comment.
@cexbrayat left one comment. Otherwise, LGTM
mgechev
left a comment
mgechev
left a comment
There was a problem hiding this comment.
object-literal-key-quotes seems the only config to fix.
Updates the `tslint.json` file to extend to the `tslint:recommended` set. Removes the rules that have the same value as the recommended one and explicitely deactivates some rules that are activated in the recommended set, but were not in ours.
cexbrayat
force-pushed
the
feat/extend-tslint-recommended
branch
from
23945da to
6d72396
Compare
|
@mgechev good catch: I added |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Updates the
tslint.jsonfile to extend to thetslint:recommendedset.Removes the rules that have the same value as the recommended one and explicitely deactivates some rules that are activated in the recommended set, but were not in ours.
Fixes #6179
cc @mgechev this is to start the discussion, feedback welcome