feat(@schematics/angular): activate recommended tslint rules#13427
Merged
kyliau merged 1 commit intoangular:masterfrom Jan 14, 2019
Merged
feat(@schematics/angular): activate recommended tslint rules#13427kyliau merged 1 commit intoangular:masterfrom
kyliau merged 1 commit intoangular:masterfrom
Conversation
clydin
requested changes
Jan 13, 2019
Member
clydin
left a comment
clydin
left a comment
There was a problem hiding this comment.
Looks good except for two rules.
cexbrayat
force-pushed
the
feat/tslint-activate-rules
branch
from
ffb4459 to
c743e29
Compare
Member
Author
|
@clydin Thanks for the review. For now, I deactivated |
cexbrayat
force-pushed
the
feat/tslint-activate-rules
branch
from
c743e29 to
c0e5ccc
Compare
clydin
approved these changes
Jan 14, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #13213 made
tslint.jsonextendtslint:recommended.As a first step, we deactivated explicitely all rules that were in the recommended set but were not in the old
tslint.jsonfile to keep the exact same configuration.This PR activates a few of the recommended rules that were explicitely deactiviated, making te confoguration closer to the recommended one, and shorter. I tried to keep the "Angular style guide" and chose to activate the ones that I think are not controversial. Let me know what you think.
cc @mgechev