feat: webpack plugin to support AoT natively by hansl · Pull Request #2333 · angular/angular-cli

hansl · 2016-09-24T17:59:55Z

No description provided.

googlebot · 2016-09-24T17:59:56Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

hansl · 2016-09-24T18:01:12Z

Both @robwormald and I are Google employees and therefore agree to the CLA.

robwormald · 2016-09-26T02:22:11Z

packages/webpack/src/plugin.ts

+        this.lazyRoutes = lazyModules.reduce((lazyRoutes: any, lazyModule: any) => {
+          lazyRoutes[`${lazyModule}.ngfactory`] = path.join(
+            path.resolve(process.cwd(), this.angularCompilerOptions.genDir),
+            'app', lazyModule + '.ngfactory.ts'


i realized this is hardcoded and would fail for anything other than app - should be I guess the relative path between the ngfactory directory and the app's root.

TheLarkInn · 2016-09-27T03:42:22Z

packages/webpack/src/loader.ts

+
+// Super simple TS transpiler loader for testing / isolated usage. does not type check!
+export function ngcLoader(source: string) {
+  const plugin = this._compilation._ngToolsWebpackPluginInstance as NgcWebpackPlugin;


This may be fine for now and once we drop webpack v2. I'm not sure when we are going to start giving deprecation warnings though for trying to access _compilation.

cc @sokra when he gets back from vacation. Maybe we need to have a way to supress warnings of these deprecations of this._compilation being unavailable from loaders on a per-plugin basis. That way this usage is acceptable for now, but in the future we can tail it off.

I really want to make a point that we need access to compilation in many cases, inside the loaders.

Or at least access to plugins, yes.

TheLarkInn · 2016-09-27T05:11:08Z

packages/webpack/src/resource_loader.ts

+
+
+
+export class WebpackResourceLoader implements ResourceLoader {


Since I haven't looked at ResourceLoader I don't really know, but since this replaces angular2-template-loader and family, we probably are going to end up with some sad folks because they can't use sass/less/styl inside of components. But, at the cost of AoT, first pass with room to refactor, its justifiable. Just means there is a lot more responsibility on the ResourceLoader to handle all these things.

If that is the case I would suggest making AOT a separate option for build because I do see that breaking a LOT of peoples builds.

@TheLarkInn I don't know what you're talking about, this was a requirement from the design phase. This resource loader compiles the resources asked for the component and as such will use the loaders.

Yup it was misunderstanding until I loaded it and tried myself. It makes perfect sense what you are doing.

TheLarkInn

Of course the regex but you said you were going to get to that.

TheLarkInn · 2016-09-28T00:37:48Z

tests/e2e/assets/webpack/test-app/webpack.config.js

+      { test: /\.scss$/, loaders: ['raw-loader', 'sass-loader'] },
+      { test: /\.css$/, loader: 'raw-loader' },
+      { test: /\.html$/, loader: 'raw-loader' },
+      { test: /\.ts$/, loader: '@ngtools/webpack' }


We thinking about changing name of loader for the future? Not really worried but I'm sure theres some post merge 🚲 shedding to be done haha.

I guess since this is the test app, its really not a big deal at all.

I'm not thinking of changing it, but we could. What were you thikning of?

Not sure yet, this is fine.

TheLarkInn

deebloo · 2016-09-28T01:04:29Z

You guys are killing it! Looking forward to this very much

Also adding a new package, webpack, which is a plugin and loader for webpack that adds support for AoT. It is behind a `--aot` flag in the CLI that is supported by build and serve.

googlebot · 2016-09-28T01:56:59Z

CLAs look good, thanks!

ginsleepy · 2016-09-29T13:37:27Z

Does this work with lazy loading?
It says "Cannot find module 'app/about/about.module.ngfactory'"

it is not generating chunk.js file either. Also I cannot find any class related to the Module in main.bundle.js

ghost · 2016-09-29T22:03:22Z

How would I use this? There's no documentation in the commits as far as I can see?

shprink · 2016-09-29T22:13:15Z

@rolandoldengarm use --aot option

Also adding a new package, webpack, which is a plugin and loader for webpack that adds support for AoT. It is behind a `--aot` flag in the CLI that is supported by build and serve.

fkolar · 2016-10-06T05:56:03Z

While looking at this push: d296778

Does it mean it will be offically supported in the next version of Angular-cli version 17?

Unless somebody wants to pull master ?

thanks,
-fk

achimha · 2016-10-09T07:07:10Z

Is there any documentation available? I've been trying to get it to work for some time now. It doesn't build my lazily loaded routes and complains about the ngfactory files not found.

Are there any changes for bootstrapping the app?

filipesilva · 2016-10-10T13:38:10Z

@achimha all changes needed should be done in memory.

We don't yet have documentation but basically you can use the --aot flag in build/serve and... that should be all really. There might still be a few bugs, though. See this label for listing: https://github.com/angular/angular-cli/issues?q=is%3Aopen+is%3Aissue+label%3A%22feature%3A+aot%22

angular-automatic-lock-bot · 2019-09-10T05:40:50Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: no label Sep 24, 2016

hansl force-pushed the aot branch 3 times, most recently from 3550f17 to 20367f4 Compare September 24, 2016 18:27

hansl added cla: yes and removed cla: no labels Sep 24, 2016

googlebot added cla: no and removed cla: yes labels Sep 25, 2016

hansl force-pushed the aot branch from 0a807e6 to bf822f4 Compare September 25, 2016 23:38

robwormald reviewed Sep 26, 2016

View reviewed changes

hansl force-pushed the aot branch 14 times, most recently from 2be135e to d6fbf39 Compare September 27, 2016 00:44

hansl mentioned this pull request Sep 27, 2016

Add project source dir as a module solution #2210

Closed

hansl force-pushed the aot branch 2 times, most recently from 42df2c8 to 6b0d77e Compare September 27, 2016 01:32

TheLarkInn reviewed Sep 27, 2016

View reviewed changes

TheLarkInn approved these changes Sep 27, 2016

View reviewed changes

hansl force-pushed the aot branch 5 times, most recently from 1ae9b65 to 4989a45 Compare September 27, 2016 23:42

TheLarkInn reviewed Sep 28, 2016

View reviewed changes

TheLarkInn approved these changes Sep 28, 2016

View reviewed changes

Brocco approved these changes Sep 28, 2016

View reviewed changes

Brocco added the pr_action: merge label Sep 28, 2016

feature(compiler): add support for AoT to the CLI.

df5eeaf

Also adding a new package, webpack, which is a plugin and loader for webpack that adds support for AoT. It is behind a `--aot` flag in the CLI that is supported by build and serve.

hansl force-pushed the aot branch from 0d14dc8 to df5eeaf Compare September 28, 2016 01:56

googlebot added cla: yes and removed cla: no labels Sep 28, 2016

hansl merged commit d296778 into angular:master Sep 28, 2016

filipesilva mentioned this pull request Oct 3, 2016

feature(compiler): add AoT compilation + lazy route bundling #2315

Closed

hansl deleted the aot branch November 2, 2016 18:01

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019




		export class WebpackResourceLoader implements ResourceLoader {

Conversation

hansl commented Sep 24, 2016

Uh oh!

googlebot commented Sep 24, 2016

Uh oh!

hansl commented Sep 24, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheLarkInn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheLarkInn left a comment

Choose a reason for hiding this comment

Uh oh!

deebloo commented Sep 28, 2016

Uh oh!

googlebot commented Sep 28, 2016

Uh oh!

ginsleepy commented Sep 29, 2016

Uh oh!

ghost commented Sep 29, 2016

Uh oh!

shprink commented Sep 29, 2016

Uh oh!

fkolar commented Oct 6, 2016

Uh oh!

achimha commented Oct 9, 2016

Uh oh!

filipesilva commented Oct 10, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants