feat(blueprints): adding generation of routing config#342
feat(blueprints): adding generation of routing config#342zackarychapple merged 1 commit intoangular:masterfrom zackarychapple:cli-generated-route
Conversation
zackarychapple
added
the
feature
| .join('\n'); | ||
|
|
||
| routeDefinitions = ngCliConfig.routes.map(route => | ||
| `{path:'${route.routePath}', name: '${route.component}', component: ${route.component}},` |
There was a problem hiding this comment.
I think there should be support for useAsDefault (but it's probably not directly related to this PR).
There was a problem hiding this comment.
Missing whitespace after path:.
There was a problem hiding this comment.
There is a fair argument towards useAsDefault being necessary for this PR: without it being supported by code generation, there is no way for a user to do it himself for these managed routes.
There was a problem hiding this comment.
@gkalpak I will do the useAsDefault as part of another commit because I want to properly wrap it with tests.
|
This looks pretty good to me, great job @zackarychapple ! Tests are quite thorough, which was important with the config based code gen, so well done. Regarding the |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
feat(blueprints): adding generation of routing config
adding automatic routing generation by default with option to not generate for application via
skip-router-generationcloses #287, closes #292