feat(@angular/cli): allow component css imports#4667
Merged
hansl merged 1 commit intoangular:masterfrom Feb 14, 2017
Merged
Conversation
clydin
reviewed
Feb 13, 2017
| const commonLoaders = [ | ||
| // css-loader doesn't support webpack.LoaderOptionsPlugin properly, | ||
| // so we need to add options in its query | ||
| `css-loader?${JSON.stringify({ sourceMap: cssSourceMap })}`, |
Member
There was a problem hiding this comment.
Adding importLoaders=1 to css-loader's options will allow any imports it handles to be processed by the PostCSS pipeline.
clydin
reviewed
Feb 13, 2017
| let rules: any = baseRules.map(({test, loaders}) => ({ | ||
| exclude: globalStylePaths, test, loaders: ['raw-loader', ...commonLoaders, ...loaders] | ||
| exclude: globalStylePaths, test, loaders: [ | ||
| 'exports-loader?module.exports.toString()', |
Member
There was a problem hiding this comment.
You'll need a comment with require('exports-loader') at the top of the file with the others.
filipesilva
force-pushed
the
fix-component-imports
branch
from
cd6bd7f to
e956d2c
Compare
clydin
approved these changes
Feb 13, 2017
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 17, 2017
Fixing component css in angular#4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using `--base-href` and/or `--deploy-url`. Fix angular#4778 Fix angular#4782
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 17, 2017
Fixing component css in angular#4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using `--base-href` and/or `--deploy-url`. Fix angular#4778 Fix angular#4782
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 18, 2017
Fixing component css in angular#4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using `--base-href` and/or `--deploy-url`. Fix angular#4778 Fix angular#4782
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 18, 2017
Fixing component css in angular#4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using `--base-href` and/or `--deploy-url`. Fix angular#4778 Fix angular#4782
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 20, 2017
Fixing component css in angular#4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using `--base-href` and/or `--deploy-url`. It also fixes asset output on `--aot` mode. Fix angular#4778 Fix angular#4782 Fix angular#4806
filipesilva
added a commit
that referenced
this pull request
Feb 20, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
Fixing component css in angular#4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using `--base-href` and/or `--deploy-url`. It also fixes asset output on `--aot` mode. Fix angular#4778 Fix angular#4782 Fix angular#4806
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4285