fix(@angular/cli): fix css url processing #4803
Conversation
5fe92b7 to
f952c9e
Compare
856d36d to
3fadf6a
Compare
|
Still having some problems with the eject config, I need to ask @hansl for advice on it next week. |
Fixing component css in angular#4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using `--base-href` and/or `--deploy-url`. It also fixes asset output on `--aot` mode. Fix angular#4778 Fix angular#4782 Fix angular#4806
2806ba9 to
0f75bbd
Compare
77f65de to
98d654d
Compare
|
@filipesilva thanks for the fix. Do you know when it will be release and/or if there is a workaround in the meantime? |
|
@omargon workaround would be to use absolute image paths. This will come out next release, which should be early next week I think. |
|
@filipesilva thanks. |
|
I'm serving assets on a subdomain, and I need to set the deployUrl=http://sub.domain.com/, this worked on version beta26, but now with rc1 this is broken, and I think it is because of this fix you have done here. |
|
@es-lab please open an issue so that we can properly assist you. |
Fixing component css in angular#4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using `--base-href` and/or `--deploy-url`. It also fixes asset output on `--aot` mode. Fix angular#4778 Fix angular#4782 Fix angular#4806
|
background: url('assets/client/img.png') is throwing compilation error for ng build -prod |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixing component css in #4667 uncovered errors in CSS url processing.
This PR correctly composes absolute urls when using
--base-hrefand/or--deploy-url.It also fixes asset output on
--aotmode. Thanks to @clydin for finding out assets were being dropped in the child compiler.Fix #4778
Fix #4782
Fix #4806