fix(ivy): @Host should behave as in View Engine by marclaval · Pull Request #27646 · angular/angular

marclaval · 2018-12-13T10:15:33Z

This PR follows discussions that happened in #27387 and #27444.

The implemented rule is: when @Host is added, from the host itself, only viewProviders and the component can be found, providers and other directives can't.

mary-poppins · 2018-12-13T10:19:35Z

You can preview 313f1b7 at https://pr27646-313f1b7.ngbuilds.io/.

mary-poppins · 2018-12-13T14:08:45Z

You can preview 4db17b3 at https://pr27646-4db17b3.ngbuilds.io/.

mary-poppins · 2018-12-13T14:28:50Z

You can preview 6df045a at https://pr27646-6df045a.ngbuilds.io/.

mary-poppins · 2018-12-13T14:48:12Z

You can preview 930f2f1 at https://pr27646-930f2f1.ngbuilds.io/.

mary-poppins · 2018-12-13T15:26:17Z

You can preview 835ed8c at https://pr27646-835ed8c.ngbuilds.io/.

mary-poppins · 2018-12-13T15:38:46Z

You can preview ffd86aa at https://pr27646-ffd86aa.ngbuilds.io/.

kara

Nits

packages/core/test/render3/di_spec.ts

packages/core/src/render3/di.ts

packages/core/src/render3/util.ts

mary-poppins · 2018-12-17T15:33:19Z

You can preview fb1e95d at https://pr27646-fb1e95d.ngbuilds.io/.

mary-poppins · 2018-12-17T15:46:11Z

You can preview 10492fc at https://pr27646-10492fc.ngbuilds.io/.

packages/core/src/render3/util.ts

mary-poppins · 2018-12-19T11:29:13Z

You can preview c718b17 at https://pr27646-c718b17.ngbuilds.io/.

kara

LGTM

kara · 2018-12-19T18:21:31Z

presubmit

angular-automatic-lock-bot · 2019-09-14T11:22:01Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Dec 13, 2018

marclaval force-pushed the hostInjection branch from 313f1b7 to 4db17b3 Compare December 13, 2018 14:04

marclaval force-pushed the hostInjection branch from 4db17b3 to 6df045a Compare December 13, 2018 14:24

marclaval force-pushed the hostInjection branch from 6df045a to 930f2f1 Compare December 13, 2018 14:43

marclaval force-pushed the hostInjection branch from 930f2f1 to 835ed8c Compare December 13, 2018 15:22

marclaval force-pushed the hostInjection branch from 835ed8c to ffd86aa Compare December 13, 2018 15:34

marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Dec 13, 2018

ngbot bot added this to the needsTriage milestone Dec 13, 2018

kara suggested changes Dec 14, 2018

View reviewed changes

kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 14, 2018

mhevery self-assigned this Dec 14, 2018

marclaval force-pushed the hostInjection branch from fb1e95d to 10492fc Compare December 17, 2018 15:41

kara suggested changes Dec 17, 2018

View reviewed changes

packages/core/src/render3/util.ts Outdated Show resolved Hide resolved

marclaval force-pushed the hostInjection branch from 10492fc to c718b17 Compare December 19, 2018 11:25

marclaval added 3 commits December 19, 2018 12:26

fix(ivy): @host should behave as in View Engine

8a252f9

fixup! fix(ivy): @host should behave as in View Engine

5f3e0ea

fixup! fix(ivy): @host should behave as in View Engine

c718b17

kara approved these changes Dec 19, 2018

View reviewed changes

kara removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 19, 2018

kara added the action: merge The PR is ready for merge by the caretaker label Dec 19, 2018

matsko closed this in 8f8572f Dec 19, 2018

mhevery mentioned this pull request Jan 2, 2019

fix(ivy): align injection behavior between ivy and ViewEngine #27444

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Conversation

marclaval commented Dec 13, 2018

Uh oh!

mary-poppins commented Dec 13, 2018

Uh oh!

mary-poppins commented Dec 13, 2018

Uh oh!

mary-poppins commented Dec 13, 2018

Uh oh!

mary-poppins commented Dec 13, 2018

Uh oh!

mary-poppins commented Dec 13, 2018

Uh oh!

mary-poppins commented Dec 13, 2018

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented Dec 17, 2018

Uh oh!

mary-poppins commented Dec 17, 2018

Uh oh!

Uh oh!

mary-poppins commented Dec 19, 2018

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

kara commented Dec 19, 2018

Uh oh!

angular-automatic-lock-bot bot commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants