Conversation
|
also do you have any idea why the test is failing? It seems that we should be able to get the text size via text-size style, just like the axis ticks etc. |
|
Hi @tdhock , thanks for the follow-up! |
|
|
||
| strip.background = element_rect(fill = "grey85", colour = NA), | ||
| strip.text = element_text(colour = "grey10", size = rel(0.8)), | ||
| strip.text = element_text(colour = "grey10"), |
There was a problem hiding this comment.
So we will remove the rel size in animint2 aesthetic?
There was a problem hiding this comment.
Thanks for your review @Faye-yufan and for the fix in the tests.
I'm not sure I understand the question. I think rel is ok to use still, but this deletion of strip.text property was intended to increase the text size of the strip text, does that make sense?
There was a problem hiding this comment.
Yeah sure! I get it now.
this is a follow-up to #66 and #78
I implemented custom text sizes that can be specified in R code, for plot and panel/strip titles.
Since this is very similar to your GSOC project last year @Faye-yufan can you please review?