Skip to content

SimpleProxyBase.testCompactionSelector should not be passing #71

@DomGarguilo

Description

@DomGarguilo

In 65fd1bb I pushed some changes to wrap the Wait.waitFor() blocks in the tests in assertTrue(). The Wait.waitFor() method will not fail on its own and simply returns a boolean which was being ignored in all of the tests, and still is being ignored in testCompactionSelector.

The condition in the test,

Wait.waitFor(() -> countFiles(tableName) == (expectedFileCount / 2));

checks to make sure that half of the files were compacted in accordance with the SelectHalfSelector being used in the test. After correctly checking the return value for this condition, it is evident that the selector is not working as intended and the number of files does not change after compaction.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions