Skip to content

Conversation

@DomGarguilo
Copy link
Member

Fixes #71

@DomGarguilo
Copy link
Member Author

Currently, the changes in this PR make it so that the condition that was trying to be assessed, that the compation selector is working, is actually being assessed. This is causing the test to fail because something is wrong and the file count is not changing as expected.

The message that prints out when the tests fails is: Expected to find 13 files but found 26

@DomGarguilo DomGarguilo changed the title WIP - fix CompactionSelecor test Fix CompactionSelecor test Feb 7, 2023
@DomGarguilo
Copy link
Member Author

Marking this as ready for review. I changed the Selector used in the test to the TooManyDeletesSelector. I modified the test to use this selector and based it off of CompactionExecutorIT.testTooManyDeletes. The point of the test is to make sure a selector can be specified from the proxy client and will take affect during compactions.

@DomGarguilo DomGarguilo merged commit 9520eec into apache:main Feb 7, 2023
@DomGarguilo DomGarguilo deleted the fixCompactionSelectorTest branch February 7, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SimpleProxyBase.testCompactionSelector should not be passing

2 participants