Skip to content

Conversation

@DomGarguilo
Copy link
Member

Fixes #53

Refactored out non-api code.

In most cases the imports were just being used to grab a String e.g. a class name. For those cases I just hardcoded a final String to use in their place.

@DomGarguilo
Copy link
Member Author

I am still looking into how FastFormat might be refactored out. I know that String.format is a lot slower so wanted to get some feedback on if that is acceptable to use in this case or if something else should be done such as creating a method to reproduce the functionality of FastFormat.

Copy link
Contributor

@milleruntime milleruntime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for looking into this! As for the FastFormat class, that is a quite useful utility. I am fine with leaving it as an exception. The easiest solution would be to just copy the class into testing since I doubt it will be changing any time soon.

@DomGarguilo
Copy link
Member Author

The easiest solution would be to just copy the class into testing since I doubt it will be changing any time soon.

I went ahead and did that. All of the exceptions should be accounted for now.

Copy link
Contributor

@milleruntime milleruntime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!

@DomGarguilo DomGarguilo merged commit e89cd6d into apache:main Sep 10, 2021
@DomGarguilo DomGarguilo deleted the refactorExceptions branch September 10, 2021 19:11
Manno15 pushed a commit to Manno15/accumulo-testing that referenced this pull request Oct 1, 2021
Removed or replaced usages of non-API code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor out Non API code

4 participants