-
Notifications
You must be signed in to change notification settings - Fork 39
Refactor out Non API code #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am still looking into how FastFormat might be refactored out. I know that String.format is a lot slower so wanted to get some feedback on if that is acceptable to use in this case or if something else should be done such as creating a method to reproduce the functionality of FastFormat. |
milleruntime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for looking into this! As for the FastFormat class, that is a quite useful utility. I am fine with leaving it as an exception. The easiest solution would be to just copy the class into testing since I doubt it will be changing any time soon.
src/main/java/org/apache/accumulo/testing/performance/tests/HighSplitCreationPT.java
Outdated
Show resolved
Hide resolved
I went ahead and did that. All of the exceptions should be accounted for now. |
src/main/java/org/apache/accumulo/testing/ingest/VerifyIngest.java
Outdated
Show resolved
Hide resolved
milleruntime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements!
Removed or replaced usages of non-API code
Fixes #53
Refactored out non-api code.
In most cases the imports were just being used to grab a String e.g. a class name. For those cases I just hardcoded a
final Stringto use in their place.