Skip to content

Conversation

@DomGarguilo
Copy link
Member

While working on #150 I noticed the following while building:

[WARNING] /home/dgarguilo/github/accumulo-testing/src/main/java/org/apache/accumulo/testing/scalability/Run.java:[83,9] newInstance() in java.lang.Class has been deprecated

It looks like newInstance() has been deprecated and replaced by getDeclaredConstructor().newInstance().

@milleruntime
Copy link
Contributor

The Scalability test is pretty old and I don't know of anyone that has run the test in a while. It might be worth it as a follow on to run it and update it. It may be still be a useful test.

@DomGarguilo
Copy link
Member Author

The Scalability test is pretty old and I don't know of anyone that has run the test in a while. It might be worth it as a follow on to run it and update it. It may be still be a useful test.

I'll go ahead and merge this for now then take a closer look at the scalability test. Was there anything in particular you had in mind in terms of updating it?

@DomGarguilo DomGarguilo merged commit 73d6314 into apache:main Sep 10, 2021
@DomGarguilo DomGarguilo deleted the newInstanceReplacement branch September 10, 2021 19:10
@milleruntime
Copy link
Contributor

The Scalability test is pretty old and I don't know of anyone that has run the test in a while. It might be worth it as a follow on to run it and update it. It may be still be a useful test.

I'll go ahead and merge this for now then take a closer look at the scalability test. Was there anything in particular you had in mind in terms of updating it?

Mostly just test to make sure it still works. I took a quick look at the classes and one thing we could do is make a helper script in <testing-home>/bin like we do with the other tests. That would make it easier to run at least.

Manno15 pushed a commit to Manno15/accumulo-testing that referenced this pull request Oct 1, 2021
Replaced the use of the deprecated newInstance() method with its replacement getDeclaredConstructor().newInstance()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants