Prefer splitting over compacting #5105
Conversation
If a tablet needs to both split and compact it is better to split first and compact after splitting so that the compaction work can be divided up better This close apache#5101
|
I'm curious if it's possible for a tablet to be in the NEEDS_SPLITTING state, but doesn't split for some reason, and then neither splits or compactions occur. |
I'll let @keith-turner comment too as he would know better but each time TGW runs it should recompute things so if a tablet was marked a needing to be split but then something changed I would think it would remove that marking and it could compact. I'm not sure if there is some other issue that would prevent splitting, maybe if the tablet couldn't be reserved but i'd think that would maybe block compaction too. The only other thing I could think of was if splits were happening so rapidly they blocked compactions but I asked @keith-turner and he didn't think this was a big concern. |
|
It looks like the TabletManagementIterator will always return |
We could try to make the the thread pool shink and grow based on demand. However its max size should always be configurable IMO. We can not grow the pool unbounded. |
3 participants
If a tablet needs to both split and compact it is better to split first and compact after splitting so that the compaction work can be divided up better
This close #5101