Skip to content

Prefer splitting over compacting #5105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cshannon merged 1 commit into from
Nov 24, 2024
Merged

Prefer splitting over compacting #5105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,16 +606,24 @@ private TableMgmtStats manageTablets(Iterator<TabletManagement> iter,
state, goal, actions, tm.getLogs().size());
}

if (actions.contains(ManagementAction.NEEDS_SPLITTING)) {
final boolean needsSplit = actions.contains(ManagementAction.NEEDS_SPLITTING);
if (needsSplit) {
LOG.debug("{} may need splitting.", tm.getExtent());
manager.getSplitter().initiateSplit(new SeedSplitTask(manager, tm.getExtent()));
}

if (actions.contains(ManagementAction.NEEDS_COMPACTING) && compactionGenerator != null) {
var jobs = compactionGenerator.generateJobs(tm,
TabletManagementIterator.determineCompactionKinds(actions));
LOG.debug("{} may need compacting adding {} jobs", tm.getExtent(), jobs.size());
manager.getCompactionCoordinator().addJobs(tm, jobs);
// Check if tablet needs splitting, priority should be giving to splits over
// compactions because it's best to compact after a split
if (!needsSplit) {
var jobs = compactionGenerator.generateJobs(tm,
TabletManagementIterator.determineCompactionKinds(actions));
LOG.debug("{} may need compacting adding {} jobs", tm.getExtent(), jobs.size());
manager.getCompactionCoordinator().addJobs(tm, jobs);
} else {
LOG.trace("skipping compaction job generation because {} may need splitting.",
tm.getExtent());
}
}

if (actions.contains(ManagementAction.NEEDS_LOCATION_UPDATE)
Expand Down