AGE PG12.1.0 ALPHA #246

muhammadshoaib · 2022-08-12T09:15:46Z

This is an initial version of AGE for PG12.

Co-authored-by: Alex Kwak emotionbug@apache.org
Co-authored-by: Ibrar Ahmad ibrar.ahmed@percona.com
Co-authored-by: Josh Innis JoshInnis@gmail.com
Co-authored-by: John Gemignani jrgemignani@gmail.com

Added upgrade script for 1.0.0 to 1.1.0

Upgrade AGE version to 1.1.0

Updated NOTICE file to remove 'incubating'

age-pg-1

ibrarahmad

Do we stop providing the upgrade?

ibrarahmad · 2022-08-17T17:00:22Z

src/backend/executor/cypher_set.c

-        &update_indexes = update_result == TM_Ok && !HeapTupleIsHeapOnly(tuple);
-
+
        // Insert index entries for the tuple


Don't use "//" comments, it is prohibited in PostgreSQL code. You can always use /* */.

It was decided at the beginning of the project to allow // for comments as our product is an extension and not a fork. I don't think this applies to extensions.

Oh, I don't know, you already decided that. PostgreSQL and all contrib extensions do not use these. Secondly, its for C++ code.

Yeah, they are not my favorite type of comment. But, it was decided as a group at the beginning of the AGE project, before Apache. Any change would have to be decided as a group. Unless, it were deemed to be necessary to change it.

ibrarahmad · 2022-08-17T17:02:39Z

.github/workflows/installcheck.yml

+          export PG_CONFIG=$HOME/pg12/bin/pg_config 
+          make -j$(nproc)
+          make install
+          make installcheck


Every file need to have one blank like at the end.

Why is this?

Actually, if we follow all PostgreSQL coding rules, it will be easy to run pgident and merge. All of the extensions are doing that. But it's my experience and opinion.

But, this means all of PGs coding rules, correct? Including their indentations and use of tabs? We left all that behind at the start of the project.

Don't worry, we will fix them one by one afterwards, for indentation, I will run pgident that fixes space and indentation issues.

What indentation issues? Our coding standard is to use 4 spaces (not a tab) for indentation. Please do not automatically run anything that will reformat files in the AGE repo. Changes like this need to be reviewed by the group before any action is taken.

I agree, @jrgemignani, that is what we already decided, and I don't want to run any tool without a final agreement. My point is our code is based on PostgreSQL, and for PostgreSQL, even we have copied most of the code from PostgreSQL code. We should make some progress to match PostgreSQL coding guidelines. Not now, but start thinking over that. It will ease our job of the future merging of code, and we can also use PostgreSQL indentation tools in future.

ibrarahmad · 2022-08-17T17:02:51Z

.gitignore

 .idea
 .deps
-.DS_Store
+.DS_Store


Every file need to have one blank like at the end.

muhammadshoaib · 2022-08-17T18:34:57Z

No, but we don't support the previous releases of AGE for PG12.

2) oid caching code restored 3) whitespace removed

1) regression test restored 2) oid caching code restored 3) whitespace removed 4) copyrights added

jirutka · 2022-08-22T00:21:37Z

updated cypher_kwlist.h

This is not a very useful commit message; there are many (probably unrelated) changes, including formatting changes.

1) regression test restored 2) oid caching code restored 3) whitespace removed 4) copyrights added

jrgemignani · 2022-08-23T18:13:38Z

Looks good to me. I have no further issues at this time.

ibrarahmad

The commit message is "updated cypher_kwlist.h". and we have changed multiple files in that commit.

ibrarahmad · 2022-08-23T19:49:20Z

src/backend/executor/cypher_delete.c

     * one has this vertex as a start or end vertex.
     */
-    foreach (lc, labels)
+    foreach(lc, labels)


What are these change?

ibrarahmad · 2022-08-23T19:50:36Z

src/backend/executor/cypher_set.c

+        
        resultRelInfo = create_entity_result_rel_info(
            estate, css->set_list->graph_name, label_name);
+        //relid = RelationGetRelid(resultRelInfo->ri_RelationDesc); 


Don't understand these change?

It is probably better to pull the PR down locally and look at it there. There are enough changes made that these diffs are a bit confusing.

jrgemignani and others added 9 commits August 10, 2022 12:46

Add upgrade script for 1.0.0 to 1.1.0

aef5e1a

Added upgrade script for 1.0.0 to 1.1.0

Upgrade AGE version from 1.0.0-->1.1.0

9b67e00

Upgrade AGE version to 1.1.0

Update NOTICE file

0c1f4e7

Updated NOTICE file to remove 'incubating'

cleaned version

0b737b5

age-pg-1

updated cypher_kwlist.h

1f5d611

fix index error by Josh

7cd1d15

rebased and updated docker file

9939917

deleted updated scripts

2bcbe33

upadated travis.yml

9e646e3

muhammadshoaib requested review from JoshInnis, emotionbug, eyab, jrgemignani and sorrell August 16, 2022 13:37

muhammadshoaib mentioned this pull request Aug 17, 2022

Inital PG 12 Version #231

Closed

ibrarahmad reviewed Aug 17, 2022

View reviewed changes

1) regression test restored

e599abe

2) oid caching code restored 3) whitespace removed

muhammadshoaib force-pushed the AGE_PG12.1.0_ALPHA branch from 392cc7a to e599abe Compare August 19, 2022 10:01

muhammadshoaib added 2 commits August 19, 2022 16:43

Fixed Final Issues

0090191

1) regression test restored 2) oid caching code restored 3) whitespace removed 4) copyrights added

Fixed Final Issues

e80cb6a

1) regression test restored 2) oid caching code restored 3) whitespace removed 4) copyrights added

muhammadshoaib added 6 commits August 22, 2022 09:44

Fixed Final Issues

9749d0d

1) regression test restored 2) oid caching code restored 3) whitespace removed 4) copyrights added

Fixed Final Issues

afbb241

1) regression test restored 2) oid caching code restored 3) whitespace removed 4) copyrights added

Fixed Final Issues

69a8902

1) regression test restored 2) oid caching code restored 3) whitespace removed 4) copyrights added

Fixed Final Issues

8966d25

1) regression test restored 2) oid caching code restored 3) whitespace removed 4) copyrights added

Fixed Final Issues

a43e721

1) regression test restored 2) oid caching code restored 3) whitespace removed 4) copyrights added

Fixed Final Issues

b7a7a6d

1) regression test restored 2) oid caching code restored 3) whitespace removed 4) copyrights added

ibrarahmad reviewed Aug 23, 2022

View reviewed changes

JoshInnis merged commit a20169e into apache:AGE_PG12.1.0_ALPHA Aug 24, 2022

muhammadshoaib deleted the AGE_PG12.1.0_ALPHA branch March 23, 2023 10:58

		&update_indexes = update_result == TM_Ok && !HeapTupleIsHeapOnly(tuple);


		// Insert index entries for the tuple

AGE PG12.1.0 ALPHA #246

AGE PG12.1.0 ALPHA #246

Uh oh!

Conversation

muhammadshoaib commented Aug 12, 2022 • edited by JoshInnis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ibrarahmad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muhammadshoaib commented Aug 17, 2022

Uh oh!

jirutka commented Aug 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jrgemignani commented Aug 23, 2022

Uh oh!

ibrarahmad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

muhammadshoaib commented Aug 12, 2022 •

edited by JoshInnis

Loading

jirutka commented Aug 22, 2022 •

edited

Loading