-
Notifications
You must be signed in to change notification settings - Fork 467
AGE PG12.1.0 ALPHA #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoshInnis
merged 18 commits into
apache:AGE_PG12.1.0_ALPHA
from
muhammadshoaib:AGE_PG12.1.0_ALPHA
Aug 24, 2022
Merged
AGE PG12.1.0 ALPHA #246
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
aef5e1a
Add upgrade script for 1.0.0 to 1.1.0
jrgemignani 9b67e00
Upgrade AGE version from 1.0.0-->1.1.0
dehowef 0c1f4e7
Update NOTICE file
jrgemignani 0b737b5
cleaned version
muhammadshoaib 1f5d611
updated cypher_kwlist.h
muhammadshoaib 7cd1d15
fix index error by Josh
muhammadshoaib 9939917
rebased and updated docker file
muhammadshoaib 2bcbe33
deleted updated scripts
muhammadshoaib 9e646e3
upadated travis.yml
muhammadshoaib e599abe
1) regression test restored
muhammadshoaib 0090191
Fixed Final Issues
muhammadshoaib e80cb6a
Fixed Final Issues
muhammadshoaib 9749d0d
Fixed Final Issues
muhammadshoaib afbb241
Fixed Final Issues
muhammadshoaib 69a8902
Fixed Final Issues
muhammadshoaib 8966d25
Fixed Final Issues
muhammadshoaib a43e721
Fixed Final Issues
muhammadshoaib b7a7a6d
Fixed Final Issues
muhammadshoaib File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: PG12 Regression | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ '*' ] | ||
| pull_request: | ||
| branches: [ '*' ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Get latest commit id of PostgreSQL 12 | ||
| run: | | ||
| echo "PG_COMMIT_HASH=$(git ls-remote git://git.postgresql.org/git/postgresql.git refs/heads/REL_12_STABLE | awk '{print $1}')" >> $GITHUB_ENV | ||
|
|
||
| - name: Cache PostgreSQL 12 | ||
| uses: actions/cache@v2 | ||
| id: pg12cache | ||
| with: | ||
| path: ~/pg12 | ||
| key: ${{ runner.os }}-v1-pg12-${{ env.PG_COMMIT_HASH }} | ||
|
|
||
| - name: Install PostgreSQL 12 | ||
| if: steps.pg12cache.outputs.cache-hit != 'true' | ||
| run: | | ||
| git clone --depth 1 --branch REL_12_STABLE git://git.postgresql.org/git/postgresql.git ~/pg12source | ||
| cd ~/pg12source | ||
| ./configure --prefix=$HOME/pg12 CFLAGS="-std=gnu99 -ggdb -O0" --enable-cassert | ||
| make install -j$(nproc) > /dev/null | ||
|
|
||
| - uses: actions/checkout@v2 | ||
| - name: Regression | ||
| run: | | ||
| export PG_CONFIG=$HOME/pg12/bin/pg_config | ||
| make -j$(nproc) | ||
| make install | ||
| make installcheck | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| *.o | ||
| *.so | ||
| .gitignore | ||
| build.sh | ||
| .idea | ||
| .deps | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every file need to have one blank like at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, if we follow all PostgreSQL coding rules, it will be easy to run pgident and merge. All of the extensions are doing that. But it's my experience and opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, this means all of PGs coding rules, correct? Including their indentations and use of tabs? We left all that behind at the start of the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry, we will fix them one by one afterwards, for indentation, I will run pgident that fixes space and indentation issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What indentation issues? Our coding standard is to use 4 spaces (not a tab) for indentation. Please do not automatically run anything that will reformat files in the AGE repo. Changes like this need to be reviewed by the group before any action is taken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, @jrgemignani, that is what we already decided, and I don't want to run any tool without a final agreement. My point is our code is based on PostgreSQL, and for PostgreSQL, even we have copied most of the code from PostgreSQL code. We should make some progress to match PostgreSQL coding guidelines. Not now, but start thinking over that. It will ease our job of the future merging of code, and we can also use PostgreSQL indentation tools in future.