Skip to content

Deprecation warning for hvac read_secret_version parameter in Hashicorp Vault client #31347

@emredjan

Description

@emredjan

Apache Airflow version

2.6.1

What happened

If you're using the Hashicorp Vault as your secrets backend, any calls to the functions in vault_client.py results in warnings like below in logs:

/data/apps/.pyenv/versions/3.10.4/envs/airflow-py310/lib/python3.10/site-packages/airflow/providers/hashicorp/_internal_client/vault_client.py:357 DeprecationWarning: The raise_on_delete
d parameter will change its default value to False in hvac v3.0.0. The current default of True will presere previous behavior. To use the old behavior with no warning, explicitly set this value to True. See https://github.com/hvac/h
vac/pull/907

This is because of a breaking change in the vault client hvac package, specifically in the read_secret_version function. A previously optional parameter raise_on_deleted_version, is now defaults to False, and should be explicitly set to True for keeping the previous behavior.

What you think should happen instead

There shouldn't be any deprecation warnings, parameter needs to be set explicitly.

How to reproduce

Setup hashicorp vault as the secrets backend
Run any airflow command that needs to access the secrets backend

Operating System

RHEL 8.5

Versions of Apache Airflow Providers

apache-airflow-providers-celery==3.1.0
apache-airflow-providers-common-sql==1.4.0
apache-airflow-providers-ftp==3.3.1
apache-airflow-providers-hashicorp==3.3.1
apache-airflow-providers-http==4.3.0
apache-airflow-providers-imap==3.1.1
apache-airflow-providers-microsoft-mssql==3.3.2
apache-airflow-providers-mysql==5.0.0
apache-airflow-providers-odbc==3.2.1
apache-airflow-providers-sftp==4.2.4
apache-airflow-providers-sqlite==3.3.2
apache-airflow-providers-ssh==3.6.0

Deployment

Virtualenv installation

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions