Explicitly passing raise_on_deleted_version=True to read_secret_version in Hashicorp operator
#36532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
changed the title
romsharon98
force-pushed
the
fix/hashicorp
branch
from
9cf8b4a to
5d0d443
Compare
romsharon98
changed the title
raise_on_deleted_version=True to read_secret_version in Hashicorp operator
hussein-awala
requested changes
Jan 2, 2024
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
Could you check #31349 (review)?
romsharon98
force-pushed
the
fix/hashicorp
branch
from
c760e20 to
addf3fd
Compare
Contributor
Author
Thanks for notice it @hussein-awala ! |
hussein-awala
approved these changes
Jan 10, 2024
potiuk
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #31347
Unfortunately I don't have Hashicorp infrastructure to connect to it so I cannot check this.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.