-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add LocalToAzureDataLakeStorageOperator #10814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mik-laj, I plan to work on the missing example dags. This Operator is needed to complete the example dag and system test for adls_to_gcs. It will upload a file to Data Lake which will then be transferred to GCS. Kindly review. Thanks |
|
@michalslowikowski00 Can you look at it? |
|
@mik-laj, @michalslowikowski00, @turbaszek please check if this is necessary :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to pass empty dict in execute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it now, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This empty dictionary is necessary so I could use keyword args for the upload_file method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I see that this param is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are trying to avoid full stops in documentation.
| are not supported. | |
| are not supported |
|
Looks good to me.
There are no docs about Azure and Microsoft operators at all. You could be a pioneer and add docs and make a good example for future contributors. :) I am sorry for such late review. :( |
Yeah, I plan to actively work on example dags on this provider and some others but I'm thinking of starting it up on a separate PR. Currently, there's no SystemTest class for this provider. Do you suggest I start SystemTests with this PR or Create another one and do example dags with tests in separate PRs? |
IMHO SystemTest could be in separate PR but example dag should be in this PR. For SystemTest you need example dag anyway. |
|
Alright. Thanks |
|
if you need help, let me know. |
|
I have added the example dag. Will add a doc and system test to verify the example in a separate PR as discussed @michalslowikowski00 |
Great. Looks good for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add type annotations, please? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, otherwise those changes are not related
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a reference to how to guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding those fields to template fields.
|
Hi @turbaszek, please can you take a look once more, thanks. |
This PR adds LocalToAzureDataLakeStorageOperator. This operator will help to add system test for ADLSToGCSOperator.
Also, the upload and download methods of AzureDataLakeHook was improved to accommodate extra arguments since the documentation allows for more arguments.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.