Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Sep 11, 2021

Renaming for consistency:.

Local -> LocalFilesystem based on: LocalFilesystemToS3Operator, LocalFilesystemToGCSOperator
shorting AzureDataLakeStorage to ADLS based on: ADLSToGCSOperator.

Noting that we have other operators that use the full service name like: AzureDataLakeStorageDeleteOperator, AzureDataLakeStorageListOperator but I think the ADLS is preferred just like we use GCS rather than GoogleCloudStorage - This falls within case 6 Isolated cases of AIP-21 I will create PRs to handle them as well if we go with the shorter ADLS version.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

)


class LocalToAzureDataLakeStorageOperator(LocalFilesystemToADLSOperator):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my knowledge this file is used to test the classes migrated from contrib to providers. It's being used in

from tests.deprecated_classes import ALL, RENAMED_ALL

The LocalFilesystemToADLSOperator wasn't part of contrib. It was added directly to providers in #10814

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 12, 2021
@potiuk potiuk merged commit d119ae8 into apache:main Sep 12, 2021
@eladkal eladkal deleted the azure branch September 12, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants