-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Allow customization of probes path and host #12634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3a75d41 to
d1da283
Compare
|
I've been thinking about the whole ingress situation. Even after this and #12619 are merged, in order to get a working airflow ingress with a custom hostname and path in AWS EKS the following will be required
So there is lot of repetition and matching required, the hostname appears in I'm thinking to create yet another PR after the others are merged that takes |
chart/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we ever need different values here -- they are controlled by the same airflow.cfg so these two values should always be the same, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the values will be the same, and they need to be "in sync" also with .webserver.base_url in airflow.cfg. So now I changed so that it extract the host and path from the webserver.base_url if provided.
d1da283 to
6e282fc
Compare
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- but could use the pytest "bare" assert style please:
assert .... is None or assert {"name": ...} in ... etc.
|
No problem, changed the |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
9e64bb9 to
6ca4fc3
Compare
(cherry picked from commit 75fd5f8)
Closes #12632
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.