Fix webserver ingress annotations #12619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
@ecerulm Can you add tests to avoid regression? |
ecerulm
commented
Nov 26, 2020
Contributor
Author
|
@mik-laj I've added two tests, I had to do other changes unrelated to the ingress annotations because the current template output did not validate :
|
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
This was referenced Nov 26, 2020
The indentation under `web.annotations` was wrong (6 leading spaces
on first line, 4 on the rest) leading to
Error converting YAMl to JSON: yaml: line 32: did not find expected key
when you run helm chart with value `ingres.web.annotations`
ecerulm
force-pushed
the
fix_webserver_ingress_annotations
branch
from
e4b5f45 to
5f90b2b
Compare
ashb
approved these changes
Jan 5, 2021
Member
|
Since the chart hasn't yet been released upgrading the minimum kube version is no problem. |
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
The indentation under `web.annotations` was wrong (6 leading spaces
on first line, 4 on the rest) leading to
Error converting YAMl to JSON: yaml: line 32: did not find expected key
when you run helm chart with value `ingres.web.annotations`
(cherry picked from commit 07670ec)
cognifloyd
pushed a commit
to cognifloyd/stackstorm-k8s
that referenced
this pull request
Feb 16, 2022
The indentation under `web.annotations` was wrong (6 leading spaces
on first line, 4 on the rest) leading to
Error converting YAMl to JSON: yaml: line 32: did not find expected key
when you run helm chart with value `ingres.web.annotations`
Partial Commit Extracted From: https://github.com/apache/airflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indentation under web.annotation was wrong (6 leading spaces
on first line, 4 on the next) leading to
when more that 1 annotation was provided.
@potiuk
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.