-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add conditional to ingress apiVersion for compatibility #13459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The networking.k8s.io/v1beta1 apiVersion has existed since 1.14 -- what version are you trying to use it wiht?
|
Here is information about supported Kubernetes versions.
https://github.com/apache/airflow/tree/master/chart#prerequisites All files are also verified against the Kubernetes specification.
|
|
@ashb thanks you for review, I used 1.11.5 on production, |
|
Even kube 1.12 is now really old, 1.11 even more so. We should probably stop (officially) supporting that. |
|
Here we discussed to change that and support Kubernetes 1.14+ |
|
@mik-laj https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/ see this blog of official 1.14+ should also be compatibled. |
|
As for me, we can only support Kubernetes 1.14+, but I'm wondering if we should make additional changes. This change changes a little more code. |
|
I've merged #12619 which changes the minimum requirement to Kube 1.14 so I think we close this issue now. Sorry -- 1.11 is too old for us to support. |
Add conditional to ingress apiVersion for compatibility.
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.