Skip to content

Conversation

@junnplus
Copy link
Contributor

@junnplus junnplus commented Jan 4, 2021

Add conditional to ingress apiVersion for compatibility.

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jan 4, 2021
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The networking.k8s.io/v1beta1 apiVersion has existed since 1.14 -- what version are you trying to use it wiht?

@mik-laj
Copy link
Member

mik-laj commented Jan 4, 2021

Here is information about supported Kubernetes versions.

Kubernetes 1.12+ cluster

https://github.com/apache/airflow/tree/master/chart#prerequisites

All files are also verified against the Kubernetes specification.

BASE_URL_SPEC = "https://raw.githubusercontent.com/instrumenta/kubernetes-json-schema/master/v1.12.9"

@junnplus
Copy link
Contributor Author

junnplus commented Jan 4, 2021

@ashb thanks you for review, I used 1.11.5 on production,
I think 1.12.9+ should be compatible with extensions/v1beta1 https://github.com/instrumenta/kubernetes-json-schema/blob/master/v1.12.9/ingress-extensions-v1beta1.json#L11 @mik-laj

@ashb
Copy link
Member

ashb commented Jan 4, 2021

Even kube 1.12 is now really old, 1.11 even more so. We should probably stop (officially) supporting that.

@mik-laj
Copy link
Member

mik-laj commented Jan 4, 2021

Here we discussed to change that and support Kubernetes 1.14+
https://github.com/apache/airflow/pull/12619/files

@junnplus
Copy link
Contributor Author

junnplus commented Jan 4, 2021

@mik-laj https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/ see this blog of official

The v1.22 release will stop serving the following deprecated API versions in favor of newer and more stable API versions:

Ingress in the extensions/v1beta1 API version will no longer be served
Migrate to use the networking.k8s.io/v1beta1 API version, available since v1.14. Existing persisted data can be retrieved/updated via the new version.

1.14+ should also be compatibled.

@mik-laj
Copy link
Member

mik-laj commented Jan 4, 2021

As for me, we can only support Kubernetes 1.14+, but I'm wondering if we should make additional changes. This change changes a little more code.
https://github.com/apache/airflow/pull/12619/files
I do not currently have time to look carefully and review these changes. Could you please help me with this?

@ashb
Copy link
Member

ashb commented Jan 5, 2021

I've merged #12619 which changes the minimum requirement to Kube 1.14 so I think we close this issue now. Sorry -- 1.11 is too old for us to support.

@ashb ashb closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants