Skip to content

Conversation

@jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Jan 4, 2021

We have an SES hook, but I don't see an SES operator yet. This patch adds the boilerplate operator to pass templated arguments through to the hook.

@boring-cyborg boring-cyborg bot added the provider:amazon AWS/Amazon - related issues label Jan 4, 2021
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

github-actions bot commented Jan 4, 2021

The Workflow run is cancelling this PR. Building image for the PR has been cancelled

@mik-laj
Copy link
Member

mik-laj commented Jan 4, 2021

@jmcarp What do you think to add SES support to EmailOperator?

@jmcarp
Copy link
Contributor Author

jmcarp commented Jan 4, 2021

So, write an ses email backend? That sounds reasonable. I might want to use multiple ses credentials for different tasks, so I would like this to include an optional connection argument, if that makes sense. Other email backends seem to use environment variables or special configuration variables for credentials. Any reason not to use connections instead for ses?

@mik-laj
Copy link
Member

mik-laj commented Jan 4, 2021

we don't have a lot of email backend alternatives, so we don't have good practices. if you present the implementation, I think there will be no problems to accept it.

ps. i thought to drop the use of environment variables in sendgrid backend.

@jmcarp
Copy link
Contributor Author

jmcarp commented Feb 20, 2021

Handled in another PR!

@jmcarp jmcarp closed this Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants