Skip to content

Conversation

@jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Jan 30, 2021

Add aws ses email backend for use with EmailOperator. Replaces #13463.

@jmcarp jmcarp requested review from mik-laj and potiuk January 30, 2021 16:53
@jmcarp jmcarp force-pushed the jmcarp/ses-emailer branch from 3b93626 to 65a2a39 Compare January 30, 2021 16:53
@boring-cyborg boring-cyborg bot added the provider:amazon AWS/Amazon - related issues label Jan 30, 2021
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 30, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Jan 30, 2021

Some static check failures @jmcarp though :)

@github-actions
Copy link

The Workflow run is cancelling this PR. Building image for the PR has been cancelled

@jmcarp jmcarp force-pushed the jmcarp/ses-emailer branch from 65a2a39 to 6c235fc Compare January 31, 2021 04:40
@potiuk
Copy link
Member

potiuk commented Jan 31, 2021

Pylint errors :(. @jmcarp -> pre-commits are helpful :). I save a lot of time thanks to them :)

tests/providers/amazon/aws/utils/test_emailer.py:20:0: W0611: Unused import copy (unused-import)
tests/providers/amazon/aws/utils/test_emailer.py:21:0: W0611: Unused import os (unused-import)
tests/providers/amazon/aws/utils/test_emailer.py:22:0: W0611: Unused import tempfile (unused-import)
tests/providers/amazon/aws/utils/test_emailer.py:23:0: W0611: Unused import unittest (unused-import)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants