Optimize wait for prod images to be run after ci images #13562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change slightly optimizes waiting for prod images. Waiting for images necessarily takes one slot from jobs queue, even if those jobs do nothing at all. This is unfortunate, but seems there is no easy way to do it differently because GitHub Actions does not support yet cross-workflow dependencies. This PR optimizes waiting for images in the way that PROD images and CI images waiting happen sequentially rather than in parallell. PROD images are, as of apache#13557 prepared sequentially which means that there is no point to wait for PROD images in parallel to CI images.
ashb
reviewed
Jan 8, 2021
Member
Author
|
I tihnk this one is actually even MUST now. With the delays in queue we have, the prod wait can timeout before the prod image is built |
ashb
approved these changes
Jan 8, 2021
potiuk
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Jan 12, 2021
The most recent submodule change for actions apache#13514 was done in parallel to Optimising worklfows in apache#13562 and the job added in the apache#13562 still uses non-submodule version of check action. Also few checkout steps missed: 'submodules: recursive' input This PR fixes that and all 3rd-party actions now are used from submodule.
potiuk
added a commit
that referenced
this pull request
Jan 12, 2021
The most recent submodule change for actions #13514 was done in parallel to Optimising worklfows in #13562 and the job added in the #13562 still uses non-submodule version of check action. Also few checkout steps missed: 'submodules: recursive' input This PR fixes that and all 3rd-party actions now are used from submodule.
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
This change slightly optimizes waiting for prod images. Waiting for images necessarily takes one slot from jobs queue, even if those jobs do nothing at all. This is unfortunate, but seems there is no easy way to do it differently because GitHub Actions does not support yet cross-workflow dependencies. This PR optimizes waiting for images in the way that PROD images and CI images waiting happen sequentially rather than in parallell. PROD images are, as of #13557 prepared sequentially which means that there is no point to wait for PROD images in parallel to CI images. (cherry picked from commit 0d8536c)
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
The most recent submodule change for actions #13514 was done in parallel to Optimising worklfows in #13562 and the job added in the #13562 still uses non-submodule version of check action. Also few checkout steps missed: 'submodules: recursive' input This PR fixes that and all 3rd-party actions now are used from submodule. (cherry picked from commit eb40eea)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 23, 2021
This change slightly optimizes waiting for prod images. Waiting for images necessarily takes one slot from jobs queue, even if those jobs do nothing at all. This is unfortunate, but seems there is no easy way to do it differently because GitHub Actions does not support yet cross-workflow dependencies. This PR optimizes waiting for images in the way that PROD images and CI images waiting happen sequentially rather than in parallell. PROD images are, as of apache#13557 prepared sequentially which means that there is no point to wait for PROD images in parallel to CI images. (cherry picked from commit 0d8536c) (cherry picked from commit 8872e7f)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 23, 2021
The most recent submodule change for actions apache#13514 was done in parallel to Optimising worklfows in apache#13562 and the job added in the apache#13562 still uses non-submodule version of check action. Also few checkout steps missed: 'submodules: recursive' input This PR fixes that and all 3rd-party actions now are used from submodule. (cherry picked from commit eb40eea) (cherry picked from commit c8895bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change slightly optimizes waiting for prod images. Waiting
for images necessarily takes one slot from jobs queue, even if
those jobs do nothing at all. This is unfortunate, but seems
there is no easy way to do it differently because GitHub
Actions does not support yet cross-workflow dependencies.
This PR optimizes waiting for images in the way that PROD images
and CI images waiting happen sequentially rather than in parallell.
PROD images are, as of #13557 prepared sequentially which
means that there is no point to wait for PROD images in parallel
to CI images.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.