Add submodules in added workflow job #13631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent submodule change for actions apache#13514 was done in parallel to Optimising worklfows in apache#13562 and the job added in the apache#13562 still uses non-submodule version of check action. Also few checkout steps missed: 'submodules: recursive' input This PR fixes that and all 3rd-party actions now are used from submodule.
potiuk
force-pushed
the
use-submodules-in-added-workflows
branch
from
004905a to
3c60536
Compare
mik-laj
approved these changes
Jan 12, 2021
potiuk
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Jan 12, 2021
The apache#13631 was also problematic because checkout/action sequence was left from the original sequence (but it needs to be reverted to work). This change fixes the sequence
potiuk
added a commit
that referenced
this pull request
Jan 12, 2021
The #13631 was also problematic because checkout/action sequence was left from the original sequence (but it needs to be reverted to work). This change fixes the sequence
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
The most recent submodule change for actions #13514 was done in parallel to Optimising worklfows in #13562 and the job added in the #13562 still uses non-submodule version of check action. Also few checkout steps missed: 'submodules: recursive' input This PR fixes that and all 3rd-party actions now are used from submodule. (cherry picked from commit eb40eea)
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 23, 2021
The most recent submodule change for actions apache#13514 was done in parallel to Optimising worklfows in apache#13562 and the job added in the apache#13562 still uses non-submodule version of check action. Also few checkout steps missed: 'submodules: recursive' input This PR fixes that and all 3rd-party actions now are used from submodule. (cherry picked from commit eb40eea) (cherry picked from commit c8895bd)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 23, 2021
The apache#13631 was also problematic because checkout/action sequence was left from the original sequence (but it needs to be reverted to work). This change fixes the sequence (cherry picked from commit 7c5cdcf) (cherry picked from commit f922c6a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent submodule change for actions #13514 was done in
parallel to Optimising worklfows in #13562 and the job added in
the #13562 still uses non-submodule version of check action.
This PR fixes that and all 3rd-party actions now are used
from submodule.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.