Allow custom timetable as a DAG argument #17414
Conversation
uranusjr
requested review from
XD-DENG,
kaxil,
mik-laj and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
from
c6b7684 to
c5b4e99
Compare
uranusjr
changed the title
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
2 times, most recently
from
f693525 to
791ddec
Compare
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
4 times, most recently
from
fd59fa0 to
f4129d9
Compare
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
from
f4129d9 to
eb50fe0
Compare
uranusjr
added
the
full tests needed
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
3 times, most recently
from
54d5877 to
c1f6815
Compare
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
from
c1f6815 to
e1c553c
Compare
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
A few minor non-blocking changes.
Since I'm out I'm approving this now, but please either make the changes suggested or leave comments saying why they aren't needed (then merge without needing further approval from me)
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
3 times, most recently
from
c754edc to
74739cd
Compare
|
Static check failing due to unrelated issue. |
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
2 times, most recently
from
bc7ea67 to
d3b56fe
Compare
There was a problem hiding this comment.
Possibly __type to match with other "special" keys? Not sure
There was a problem hiding this comment.
I’m assuming we’re not yet set on the serialisation method because of the class registration stuff (and I’m not sure the current method will always work if the timetable class is declared in a DAG file), so let’s not think too hard on this for now?
All existing aceess to schedule_interval (the normalized property is not used anywhere) are all changed to use the DAG's timetable member. A couple of timetable-describing flags, can_run and periodic, are added to replace some usages that need to know about what the timetable is capable of doing. Serialization methods are added to timetable classes so the timetable can be saved to the meta database during DAG serialization.
uranusjr
force-pushed
the
aip-39-dag-accepts-timetable
branch
from
d3b56fe to
138defd
Compare
|
Registration issue opened as #17931. |
3 participants
To allow a custom
timetableargument to work on a DAG, the existingschedule_intervalattribute and thenormalized_schedule_intervalproperty are removed. All existing aceess toschedule_interval(the normalizedproperty is not used anywhere) are all changed to use the DAG's
timetablemember. A couple of timetable-describing flags,can_runandperiodic, are added to replace some usages that need to know about what the timetableis capable of doing.
Serialization methods are added to timetable classes so the timetable can be saved to the meta database during DAG serialization.
Since the
schedule_intervalattribute has been removed, the field onDagModelof the same name is also changed. Since we still need that information to display the timetable on the web UI,timetable.summaryis used to “backfill”schedule_intervalif a custom timetable is used.schedule_intervalbecomes purely cosmetic and only used to UI display.