AIP 39: Documentation #17552
Merged
AIP 39: Documentation #17552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
reviewed
Aug 11, 2021
uranusjr
force-pushed
the
aip-39-docs
branch
7 times, most recently
from
ef28489 to
dd07a4b
Compare
Member
Author
|
I created an example DAG showcasing how timetable subclassing works and finished the howto guide referencing the example DAG. I’m more or less done for now, but since the howto’s content depends on changes in #17414, this will stay a draft until that PR is merged (or at least close to it). |
ashb
reviewed
Aug 17, 2021
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
This is really clear to me (but then I'm familiar with both the code and the proposal, so I'm not the best to judge.)
Member
Author
|
Tests are failing because we haven’t actually implemented |
uranusjr
commented
Aug 24, 2021
uranusjr
commented
Aug 24, 2021
uranusjr
commented
Aug 24, 2021
jhtimmins
reviewed
Aug 28, 2021
uranusjr
force-pushed
the
aip-39-docs
branch
3 times, most recently
from
1c90094 to
2ffbf30
Compare
uranusjr
force-pushed
the
aip-39-docs
branch
from
331694b to
159b186
Compare
Member
Author
|
I think this is ready for review. In addition to the new timetable how-to page, I also rewrote many execution date and |
uranusjr
requested review from
kaxil,
mik-laj and
vikramkoka
as code owners
Member
|
(Just rebased) |
Member
|
Might need another rebase |
Not all usages can be removed, unfortunately, since there are still many usages requiring the value, especially in Python APIs. This also adds additional values for Sentry tags and Elastic log filenames based on data interval instead of execution date, so the user can migrate as soon as possible, even if we have not changed the default.
We need to use execution_date here :/
A DAG run CAN technically start before its data interval ends, but that's an edge case we shouldn't cover early in the documentation, so let's make wording vague to focus on the general cases to make things less complicated for users reading this for the first time.
A custom timetable requires plugin initialization, which is not done for unit tests. But we really don't want to automatically register that plugin since it makes testing an unregistered plugin impossible. Since that example DAG is very short and referenced only once anyway, let's just not bother.
This ensures the log ID is unique across the board, similar to the guarantee we had prior to AIP-39 (via execution date).
We don't want to expose TaskInstance(execution_date=...) anymore, but the extra link interface still relies on execution date, so we need an alternative.
54 tasks
91 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much a work in progress.Ready for review now.I have very low confidence on my ability writing comprehensive prose 🙂