-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add Next Run to UI #17732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Next Run to UI #17732
Conversation
|
Thrlilled ! That's one of those great features that look like small ones but can totally change your experience. |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
Since there are many execution_date usages to change, this will be done in a follow-up PR instead. |
| </a> | ||
| {% if dag_model is defined and dag_model.next_dagrun_create_after is defined %} | ||
| <p class="label label-default" style="margin-left: 5px"> | ||
| Next Run: <span id="next-run">{{ dag_model.next_dagrun_create_after }}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By making this a <time> element it will automatically get converted by the timezone selector (not to mention that just semantically this is a time 😁)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, I forgot that we select elements by <time> in datetime_utils.js. Fixed.
Use `<time>` to use our existing `datetime_utils` to format and handle timezone changes
|
I just noticed something. We are using |
|
I updated Next Run to use the execution date to be consistent with Last Run. I also added a tooltip for the next run to show the create after and data interval. For Last Run, I decided to extend the use of the |
uranusjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t really understand the js code, but the end result looks awesome
|
Hmm a lot of tests failing, many seem to be related to the new |



Adds info on the next run from
next_dagrunin the hoem page list of all dags and on the individual dag pages.#17726
Unfortunately,
next_dagrunonly existed onDagModeland notDagso I had to manually add it to every relevant endpoint inviews.py. I also had to do some weird js logic to format the dates in line with the rest of the UI.Also, I tried to update the copy on execution date. Open to suggestions.(Updating use ofexecution_datethroughout the UI will be a different PR)Closes #2460
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.