Wording the next and last run DAG columns better #31467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
Contributor
Author
|
@bbovenzi @potiuk need a review on this issue. I also see that the CI is failing and I cannot figure out what the issue. Any help here will be appreciated. This seems to be the issue: |
Member
|
#31518 should have solved that, can you rebase and try again ? |
bbovenzi
reviewed
May 25, 2023
| title="Starting Date/Time interval of the latest Dag Run.">info</span> | ||
| </th> | ||
| <th style="width:180px;">{{ sortable_column("Next Run", "next_dagrun") }} | ||
| <th style="width:180px;">{{ sortable_column("Next Data Interval", "next_dagrun_data_interval") }} |
Contributor
There was a problem hiding this comment.
I don't think we want to change the values, just the label, right?
Contributor
Author
There was a problem hiding this comment.
Do you mean that Last Run is the label and the last_dagrun is the value?
I went ahead and made this modification as it seemed more appropriate to change both rather than just one of them as they are related. Let me keep the changes to label only
added 2 commits
May 26, 2023 11:09
Contributor
|
Code looks good. |
Contributor
Author
Contributor
Author
|
@jedcunningham @bbovenzi can I get another round of review on this PR? |
jedcunningham
approved these changes
Jun 1, 2023
bbovenzi
approved these changes
Jun 1, 2023
eladkal
added
the
type:misc/internal
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
* Better wording the next and last run DAG columns * review comments from brent * review comments from Jed * Undoing test changes --------- Co-authored-by: Amogh <adesai@cloudera.com> (cherry picked from commit 7db42fe)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
* Better wording the next and last run DAG columns * review comments from brent * review comments from Jed * Undoing test changes --------- Co-authored-by: Amogh <adesai@cloudera.com> (cherry picked from commit 7db42fe)
62 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users tend to get confused by the words
Next RunandLast Runused in our DAG UI. These words and tooltips can be worded better to avoid getting misleading as users. Related discussions:#17732
#21493
closes: #31365
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.