Fix --github-image-id flag for Breeze #18882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we moved to github registry, the --github-image-id flag was broken as it had pulled the "latest" image when run right after pulling the tagged image (and it run that image instead). This change fixes it and uses GITHUB_PULL_IMAGE_TAG (latest if not specified) everywhere where the image is used for running. This flag is not persistent so it is not persistent.
Member
Author
|
I would love to get that one merged to be able to diagnose the "TLS" libstdc++ more easily. |
mik-laj
approved these changes
Oct 12, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 12, 2021
This reverts commit ce0b64e.
potiuk
added a commit
that referenced
this pull request
Oct 12, 2021
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 14, 2021
When we moved to github registry, the --github-image-id flag was broken as it had pulled the "latest" image when run right after pulling the tagged image (and it run that image instead). This change fixes it and uses GITHUB_PULL_IMAGE_TAG (latest if not specified) everywhere where the image is used for running. This flag is not persistent so it is not persistent.
potiuk
added a commit
that referenced
this pull request
Oct 14, 2021
When we moved to github registry, the --github-image-id flag was broken as it had pulled the "latest" image when run right after pulling the tagged image (and it run that image instead). This change fixes it and uses GITHUB_PULL_IMAGE_TAG (latest if not specified) everywhere where the image is used for running. This flag is not persistent so it is not persistent.
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
When we moved to github registry, the --github-image-id flag was broken as it had pulled the "latest" image when run right after pulling the tagged image (and it run that image instead). This change fixes it and uses GITHUB_PULL_IMAGE_TAG (latest if not specified) everywhere where the image is used for running. This flag is not persistent so it is not persistent. (cherry picked from commit 0a82a42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we moved to github registry, the --github-image-id flag was
broken as it had pulled the "latest" image when run right after
pulling the tagged image (and it run that image instead).
This change fixes it and uses GITHUB_PULL_IMAGE_TAG (latest if not
specified) everywhere where the image is used for running.
This flag is not persistent so it is not persistent.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.